Fix : Search for previous tag by Git tag, not by GitHub release #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes JuliaRegistries#194 - Use Git tags instead of GitHub releases for finding previous releases. This is more reliable because: - Not all Git tags have GitHub releases - GitHub releases can be deleted while Git tags remain - Direct tag lookup is faster and more accurate Changes: - Added get_all_tags() method to Repo class - Modified Changelog._previous_release() to use get_all_tags() - Modified Changelog._is_backport() to use get_all_tags() - Updated tests to mock get_all_tags instead of get_releases - Falls back to get_release() if a GitHub release exists for the tag This ensures TagBot can correctly identify previous versions even when GitHub releases don't exist or have been deleted.
- Use UnknownObjectException instead of broad Exception catch - Get commit datetime via time_of_commit() for fallback object - Add defensive None check for created_at in _collect_data() - Add test for fallback behavior Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_all_tags()method to theRepoclass that returns all Git tag names using the existing tags cacheChangelog._previous_release()to use Git tags instead of GitHub releasesChangelog._is_backport()to use Git tags as wellcreated_at, but falls back gracefully if it doesn't exist